-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes paginator issue since hugo v0.123.0 #170
Fixes paginator issue since hugo v0.123.0 #170
Conversation
✅ Deploy Preview for hugo-blog-awesome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi Michiel, thanks for creating this PR and for the detailed information you've provided. Could you please bump the Hugo version in hugo-blog-awesome/netlify.toml Line 10 in 0ca8845
This will allow us to test whether the fix works in Hugo version > Let me know if anything is not clear or if you have any queries. |
@hugo-sid done. Apparently there's another issue that breaks the build, has something to do with the |
@hugo-sid we've got two issues breaking the build currently, so how do you want to proceed? I can create another branch that fixes the |
@MichielVanDerWinden thank you for enabling maintainer edits for this PR. I am currently pushing a commit (as part of this PR) to fix the Also, thanks for the Hugo version bump. |
Pages of kind "page" don't allow the creation of a paginator (.Paginate or .Paginator) in the newest version of hugo. Pages of kind "section" (e.g. /posts) still allow the creation. This fix adds a check for the kind of page and excludes pages with kind "page" from creating a paginator.
To maintain full transparency I've created #171 which is duplicated by your #172 - do you want me to close my issue? |
e28185d
to
457a902
Compare
|
Ah, I saw #171 just now. Please don't delete the the issue which you have created, Michiel. It's more detailed and informative than mine. Anyways these two will be closed as soon as I merge this PR. Thanks again for the detailed issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you Michiel for taking time to contribute to Hugo blog awesome.
I truly appreciate your contribution.
What problem does this PR solve?
Pages of kind "page" don't allow the creation of a paginator (.Paginate or .Paginator) in the newest version of hugo.
Pages of kind "section" (e.g. /posts) still allow the creation. This fix adds a check for the kind of page and excludes pages with kind "page" from creating a paginator.
Is this PR adding a new feature?
No
Is this PR related to any issue or discussion?
Closes #165
PR Checklist